From: Jakub Staniszewski Correct the logic in ndo_fdb_del() to align with other drivers in upstream. The condition was inverted — it was rejecting permanent (NUD_PERMANENT) MAC addresses while allowing non-permanent ones to be deleted, which is the opposite of the intended behavior. The correct logic is to reject deletion of non-permanent entries, mirroring the fix applied to ndo_dflt_fdb_del() in commit 645359930231 ("rtnetlink: Fix inverted check in ndo_dflt_fdb_del()"). Also add is_link_local_ether_addr() to the unicast branch of ice_fdb_del() to mirror ice_fdb_add(), which already handles link-local addresses as unicast via dev_uc_add_excl(). Without this, a link-local address added via ice_fdb_add() would fall through to dev_mc_del() on deletion and fail to be removed. Fixes: e94d4478669357cd ("ice: Implement filter sync, NDO operations and bump version") Cc: stable@vger.kernel.org Signed-off-by: Jakub Staniszewski Signed-off-by: Aleksandr Loktionov --- drivers/net/ethernet/intel/ice/ice_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index d888354..4c6d863 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -6151,12 +6151,12 @@ ice_fdb_del(struct ndmsg *ndm, __always_unused struct nlattr *tb[], { int err; - if (ndm->ndm_state & NUD_PERMANENT) { + if (!(ndm->ndm_state & NUD_PERMANENT)) { netdev_err(dev, "FDB only supports static addresses\n"); return -EINVAL; } - if (is_unicast_ether_addr(addr)) + if (is_unicast_ether_addr(addr) || is_link_local_ether_addr(addr)) err = dev_uc_del(dev, addr); else if (is_multicast_ether_addr(addr)) err = dev_mc_del(dev, addr); -- 2.52.0