asd_get_tmf_resp_tasklet() extracts the empty data buffer index from the done list status block exactly as asd_get_response_tasklet() does: int edb_id = ((resp_sb->flags & 0x70) >> 4)-1; and indexes seq->edb_arr[] with it unchecked: edb = asd_ha->seq.edb_arr[edb_id + escb->edb_index]; ascb->tag = *(__be16 *)(edb->vaddr+4); The field is three bits, so the value runs from -1 to 6, and the first ESCB has edb_index 0, which makes seq->edb_arr[-1] reachable arithmetic. asd_invalidate_edb() at the end of the function uses the same value again. Apply the same check as the preceding patch and return res, which is TMF_RESP_FUNC_FAILED at that point, the way the lookup failure above it already does. The caveats are the ones on that patch: the sequencer is firmware loaded with request_firmware() and nothing in the tree describes what it may put in this field, so this is not a claim of a reachable out-of-bounds access, and a response dropped here leaves its ESCB uninvalidated and unreposted. Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver") Signed-off-by: Yehyeong Lee --- drivers/scsi/aic94xx/aic94xx_tmf.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/aic94xx/aic94xx_tmf.c b/drivers/scsi/aic94xx/aic94xx_tmf.c index 28ac92b041fe3..1ee6009d83051 100644 --- a/drivers/scsi/aic94xx/aic94xx_tmf.c +++ b/drivers/scsi/aic94xx/aic94xx_tmf.c @@ -282,6 +282,12 @@ static int asd_get_tmf_resp_tasklet(struct asd_ascb *ascb, return res; } + if (edb_id < 0 || edb_id >= ASD_EDBS_PER_SCB) { + ASD_DPRINTK("edb_id is %d! resp_sb->flags is 0x%x\n", + edb_id, resp_sb->flags); + return res; + } + edb = asd_ha->seq.edb_arr[edb_id + escb->edb_index]; ascb->tag = *(__be16 *)(edb->vaddr+4); fh = edb->vaddr + 16; -- 2.43.0