release_buff() as a function name is ambiguous: - it misses the driver prefix and, - it does not mention whether it is a Tx or Rx buffer. Signed-off-by: Théo Lebrun --- drivers/net/ethernet/cadence/macb_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index d155f4571c74..70f5dc9c6529 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -969,7 +969,7 @@ static int macb_halt_tx(struct macb *bp) bp, TSR); } -static void release_buff(void *buff, enum macb_tx_buff_type type, int budget) +static void macb_tx_release_buff(void *buff, enum macb_tx_buff_type type, int budget) { if (type == MACB_TYPE_SKB) { napi_consume_skb(buff, budget); @@ -994,7 +994,7 @@ static void macb_tx_unmap(struct macb *bp, struct macb_tx_buff *tx_buff, } if (tx_buff->ptr) { - release_buff(tx_buff->ptr, tx_buff->type, budget); + macb_tx_release_buff(tx_buff->ptr, tx_buff->type, budget); tx_buff->ptr = NULL; } } @@ -1461,7 +1461,7 @@ static int macb_xdp_submit_frame(struct macb *bp, struct xdp_frame *xdpf, spin_unlock_irqrestore(&queue->tx_ptr_lock, flags); if (err) - release_buff(xdpf, buff_type, 0); + macb_tx_release_buff(xdpf, buff_type, 0); return err; } -- 2.53.0