The shared IRQ is requested before the lock and timer its handler uses are initialized, and stays registered past free_netdev() on the probe error paths and in remove, so the handler can run on freed memory. Reproduced with CONFIG_DEBUG_SHIRQ=y and slub_debug=P and tested on an SGI Fuel. Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") Reported-by: Sashiko Closes: https://lore.kernel.org/all/179473760071.2199510.16065103101920438822@kernel.org/ Cc: stable@vger.kernel.org Signed-off-by: Imre Kaloz --- drivers/net/ethernet/sgi/ioc3-eth.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c index ee284a4f75ff..e322a588d5c4 100644 --- a/drivers/net/ethernet/sgi/ioc3-eth.c +++ b/drivers/net/ethernet/sgi/ioc3-eth.c @@ -870,16 +870,16 @@ static int ioc3eth_probe(struct platform_device *pdev) goto out_free; } - if (devm_request_irq(&pdev->dev, dev->irq, ioc3_interrupt, - IRQF_SHARED, "ioc3-eth", dev)) { + spin_lock_init(&ip->ioc3_lock); + timer_setup(&ip->ioc3_timer, ioc3_timer, 0); + + if (request_irq(dev->irq, ioc3_interrupt, IRQF_SHARED, "ioc3-eth", + dev)) { dev_err(&pdev->dev, "Can't get irq %d\n", dev->irq); err = -ENODEV; goto out_free; } - spin_lock_init(&ip->ioc3_lock); - timer_setup(&ip->ioc3_timer, ioc3_timer, 0); - ioc3_stop(ip); /* Allocate rx ring. 4kb = 512 entries, must be 4kb aligned */ @@ -951,6 +951,7 @@ static int ioc3eth_probe(struct platform_device *pdev) return 0; out_stop: + free_irq(dev->irq, dev); timer_delete_sync(&ip->ioc3_timer); if (ip->rxr) dma_free_coherent(ip->dma_dev, RX_RING_SIZE, ip->rxr, @@ -969,6 +970,7 @@ static void ioc3eth_remove(struct platform_device *pdev) struct ioc3_private *ip = netdev_priv(dev); unregister_netdev(dev); + free_irq(dev->irq, dev); timer_delete_sync(&ip->ioc3_timer); dma_free_coherent(ip->dma_dev, RX_RING_SIZE, ip->rxr, ip->rxr_dma); -- 2.47.3