From: Jakub Staniszewski Correct the logic in ndo_fdb_del() to align with other drivers in upstream. The condition was inverted — it was rejecting permanent (NUD_PERMANENT) MAC addresses while allowing non-permanent ones to be deleted, which is the opposite of the intended behavior. The correct logic is to reject deletion of non-permanent entries, mirroring the fix applied to ndo_dflt_fdb_del() in commit 645359930231 ("rtnetlink: Fix inverted check in ndo_dflt_fdb_del()"). Fixes: e94d4478669357cd ("ice: Implement filter sync, NDO operations and bump version") Signed-off-by: Jakub Staniszewski Signed-off-by: Aleksandr Loktionov --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index 348c86b..7692403 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -6200,7 +6200,7 @@ ice_fdb_del(struct ndmsg *ndm, __always_unused struct nlattr *tb[], { int err; - if (ndm->ndm_state & NUD_PERMANENT) { + if (!(ndm->ndm_state & NUD_PERMANENT)) { netdev_err(dev, "FDB only supports static addresses\n"); return -EINVAL; } -- 2.52.0