For now, including instead of is technically fine unless the .c file calls p*d_populate_kernel() helper functions. But it is a better practice to always include . Include instead of outside arch/. Signed-off-by: Harry Yoo Acked-by: David Hildenbrand Reviewed-by: Lorenzo Stoakes Reviewed-by: Mike Rapoport (Microsoft) --- drivers/firmware/efi/arm-runtime.c | 4 ++-- drivers/firmware/efi/riscv-runtime.c | 4 ++-- drivers/s390/char/sclp_sd.c | 3 +-- fs/dax.c | 2 +- kernel/fork.c | 4 ++-- mm/debug_vm_pgtable.c | 2 +- mm/filemap.c | 3 ++- mm/huge_memory.c | 2 +- mm/hugetlb.c | 2 +- mm/hugetlb_vmemmap.c | 3 ++- mm/khugepaged.c | 2 +- mm/memory.c | 4 ++-- mm/mmu_gather.c | 2 +- mm/mremap.c | 2 +- mm/pgtable-generic.c | 3 ++- mm/pt_reclaim.c | 3 ++- 16 files changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c index 83092d93f36a..53a5336cde5a 100644 --- a/drivers/firmware/efi/arm-runtime.c +++ b/drivers/firmware/efi/arm-runtime.c @@ -12,18 +12,18 @@ #include #include #include +#include +#include #include #include #include #include #include #include -#include #include #include #include -#include #if defined(CONFIG_PTDUMP_DEBUGFS) || defined(CONFIG_ARM_PTDUMP_DEBUGFS) #include diff --git a/drivers/firmware/efi/riscv-runtime.c b/drivers/firmware/efi/riscv-runtime.c index fa71cd898120..7ceb02bc57f7 100644 --- a/drivers/firmware/efi/riscv-runtime.c +++ b/drivers/firmware/efi/riscv-runtime.c @@ -14,18 +14,18 @@ #include #include #include +#include +#include #include #include #include #include #include #include -#include #include #include #include -#include static bool __init efi_virtmap_init(void) { diff --git a/drivers/s390/char/sclp_sd.c b/drivers/s390/char/sclp_sd.c index 129b89fe40a3..7a791cb35aea 100644 --- a/drivers/s390/char/sclp_sd.c +++ b/drivers/s390/char/sclp_sd.c @@ -17,8 +17,7 @@ #include #include #include - -#include +#include #include "sclp.h" diff --git a/fs/dax.c b/fs/dax.c index 89f071ba7b10..1c78fc02462c 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -24,7 +24,7 @@ #include #include #include -#include +#include #define CREATE_TRACE_POINTS #include diff --git a/kernel/fork.c b/kernel/fork.c index 3da0f08615a9..dd0bb5fe4305 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -106,9 +106,9 @@ #include #include #include - -#include +#include #include + #include #include #include diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c index def344bb4a32..e95ba87f2431 100644 --- a/mm/debug_vm_pgtable.c +++ b/mm/debug_vm_pgtable.c @@ -30,9 +30,9 @@ #include #include #include +#include #include -#include #include /* diff --git a/mm/filemap.c b/mm/filemap.c index 893ba49808b7..b7b297c1ad4f 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -48,7 +48,8 @@ #include #include #include -#include +#include + #include #include "internal.h" diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 160a701b13d1..900ae5dcb6fb 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -37,11 +37,11 @@ #include #include #include +#include #include #include #include -#include #include "internal.h" #include "swap.h" diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 86e672fcb305..1ea459723cce 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -39,9 +39,9 @@ #include #include #include +#include #include -#include #include #include diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index 96ee2bd16ee1..9d01f883fd71 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -15,7 +15,8 @@ #include #include #include -#include +#include + #include #include "hugetlb_vmemmap.h" diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 8ed9f8e2d376..4f47bf2dc541 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -21,9 +21,9 @@ #include #include #include +#include #include -#include #include "internal.h" #include "mm_slot.h" diff --git a/mm/memory.c b/mm/memory.c index 19615bcf234f..39e21688e74b 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -75,13 +75,13 @@ #include #include #include +#include +#include #include #include #include -#include -#include #include #include diff --git a/mm/mmu_gather.c b/mm/mmu_gather.c index 374aa6f021c6..247e3f9db6c7 100644 --- a/mm/mmu_gather.c +++ b/mm/mmu_gather.c @@ -9,8 +9,8 @@ #include #include #include +#include -#include #include #ifndef CONFIG_MMU_GATHER_NO_GATHER diff --git a/mm/mremap.c b/mm/mremap.c index e2a1793b43ce..a0c641cf579e 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -25,10 +25,10 @@ #include #include #include +#include #include #include -#include #include "internal.h" diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c index fc7584841c8f..d3aec7a9926a 100644 --- a/mm/pgtable-generic.c +++ b/mm/pgtable-generic.c @@ -14,7 +14,8 @@ #include #include #include -#include +#include + #include /* diff --git a/mm/pt_reclaim.c b/mm/pt_reclaim.c index 7e9455a18aae..0d9cfbf4fe5d 100644 --- a/mm/pt_reclaim.c +++ b/mm/pt_reclaim.c @@ -1,7 +1,8 @@ // SPDX-License-Identifier: GPL-2.0 #include +#include + #include -#include #include "internal.h" -- 2.43.0