do_ap_configure() allocates the SCCB used to configure and deconfigure AP adapters. This buffer can be allocated with kmalloc() as there's nothing special about it to go directly to the page allocator. kmalloc() provides a better API that does not require ugly casts and kfree() does not need to know the size of the freed object. Performance difference between kmalloc() and __get_free_pages() is not measurable as both allocators take an object/page from a per-CPU list for fast path allocations. For the slow path the performance is anyway determined by the amount of reclaim involved rather than by what allocator is used. Replace use of get_zeroed_page() with kzalloc() and free_page() with kfree(). Link: https://lore.kernel.org/all/635405e4-9423-4a25-a6e7-e03c8ea0bcbe@redhat.com Reviewed-by: Heiko Carstens Signed-off-by: Mike Rapoport (Microsoft) --- drivers/s390/char/sclp_ap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/s390/char/sclp_ap.c b/drivers/s390/char/sclp_ap.c index 18bb018b4e0c..15dff5dc0cac 100644 --- a/drivers/s390/char/sclp_ap.c +++ b/drivers/s390/char/sclp_ap.c @@ -26,7 +26,7 @@ static int do_ap_configure(sclp_cmdw_t cmd, u32 apid) if (!SCLP_HAS_AP_RECONFIG) return -EOPNOTSUPP; - sccb = (struct ap_cfg_sccb *) get_zeroed_page(GFP_KERNEL | GFP_DMA); + sccb = kzalloc(PAGE_SIZE, GFP_KERNEL | GFP_DMA); if (!sccb) return -ENOMEM; @@ -45,7 +45,7 @@ static int do_ap_configure(sclp_cmdw_t cmd, u32 apid) break; } out: - free_page((unsigned long) sccb); + kfree(sccb); return rc; } -- 2.53.0