From: Michael Baikov This commit partially undoes changes made by the commit e79255de8581 ("sfc: Do not pass non-TCP packets into GRO code"). Those changes made sense back then, but now GRO can help with more message types. Now, when GRO is enabled - pass all the messages though GRO subsystem. Tested on SFC9250 with a UDP_GRO socket. Signed-off-by: Michael Baikov --- Problem I'm trying to solve: I'm dealing with high data rate, small message size multicast UDP traffic - uniform size, addresses - a perfect candidate for UDP Generic Receive Offload (GRO). Made a prototype - it worked as expected on the desktop during development, but wasn't producing any GRO coalesced messages on the server. The server uses SFC9250 and turns out its driver only allows GRO for TCP packets. Change was made back in 2013. Expected user impact: 1. GRO will start working for UDP 2. It might add a slight overhead for UDP traffic for e10 drivers. (this bypass only exists for e10 drivers, for e100 (ef100_rx.c:140) packets are passed to GRO unconditionally First version of this patch tried to pass only UDP and TCP messages though GRO, but since it's unlikely to have a high volume traffic that is neither of those two - this version simply drops "is TCP?" check. Link: https://lore.kernel.org/all/20261018-sfc-gro-udp-v1-1-f7bf378178f8@gmail.com/ --- drivers/net/ethernet/sfc/rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/rx.c b/drivers/net/ethernet/sfc/rx.c index ffca82207e47..9874093944f8 100644 --- a/drivers/net/ethernet/sfc/rx.c +++ b/drivers/net/ethernet/sfc/rx.c @@ -401,7 +401,7 @@ void __efx_rx_packet(struct efx_channel *channel) if (unlikely(!(efx->net_dev->features & NETIF_F_RXCSUM))) rx_buf->flags &= ~EFX_RX_PKT_CSUMMED; - if ((rx_buf->flags & EFX_RX_PKT_TCP) && !channel->type->receive_skb) + if (!channel->type->receive_skb) efx_rx_packet_gro(channel, rx_buf, channel->rx_pkt_n_frags, eh, 0); else efx_rx_deliver(channel, eh, rx_buf, channel->rx_pkt_n_frags); --- base-commit: fa5196392691051963726787944db872420dfa75 change-id: 20261109-sfc-udp-gro2-456dfc3fc462 Best regards, -- Michael Baikov