When a network namespace is deleted, we free its uevent socket. But sometimes a device in that namespace is still being removed and tries to send a uevent through that socket. The socket is already freed, so KASAN reports a use-after-free. Take a lock around both the send path and the free path, and clear the pointer before freeing so nobody uses it after free. Reported-and-tested-by: syzbot+4393dfdddf166f2de2b0@syzkaller.appspotmail.com Tested-by: Adarsh Das Assisted-by: LLM Link: https://lore.kernel.org/all/20260917144206.85836-1-adarshdas950@gmail.com/ Signed-off-by: Adarsh Das --- v4: - Use scoped_guard(mutex) instead of block in uevent_net_exit v3: - Use guard(mutex) per review v2: - Add Assisted-by and Tested-by tags per review lib/kobject_uevent.c | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c index ddbc4d7482d2..14e2e15d4ea7 100644 --- a/lib/kobject_uevent.c +++ b/lib/kobject_uevent.c @@ -13,6 +13,7 @@ * Greg Kroah-Hartman */ +#include #include #include #include @@ -411,9 +412,14 @@ static int kobject_uevent_net_broadcast(struct kobject *kobj, devpath); else { const struct net *net = container_of(ns, struct net, ns); - - ret = uevent_net_broadcast_tagged(net->uevent_sock->sk, env, - action_string, devpath); + struct uevent_sock *ue_sk; + + guard(mutex)(&uevent_sock_mutex); + ue_sk = net->uevent_sock; + if (ue_sk && ue_sk->sk) + ret = uevent_net_broadcast_tagged(ue_sk->sk, env, + action_string, + devpath); } #endif @@ -804,14 +810,18 @@ static int uevent_net_init(struct net *net) static void uevent_net_exit(struct net *net) { - struct uevent_sock *ue_sk = net->uevent_sock; + struct uevent_sock *ue_sk; - if (sock_net(ue_sk->sk)->user_ns == &init_user_ns) { - mutex_lock(&uevent_sock_mutex); - list_del(&ue_sk->list); - mutex_unlock(&uevent_sock_mutex); + scoped_guard(mutex, &uevent_sock_mutex) { + ue_sk = net->uevent_sock; + net->uevent_sock = NULL; + if (ue_sk && sock_net(ue_sk->sk)->user_ns == &init_user_ns) + list_del(&ue_sk->list); } + if (!ue_sk) + return; + netlink_kernel_release(ue_sk->sk); kfree(ue_sk); } -- 2.55.0