The GMAC, GMAC4 and XGMAC rx_ipc callbacks return whether checksum offload is enabled after programming the requested state. A zero return is therefore expected when hw->rx_csum is zero. stmmac_hw_setup() treats every zero return as a lack of hardware support and clears plat->rx_coe. Disabling RX checksum offload with ethtool and then reopening the interface loses the saved capability. Subsequent attempts to enable offload are rejected by stmmac_fix_features(), which uses plat->rx_coe to filter NETIF_F_RXCSUM. Only clear the capability if offload was requested but could not be enabled. Keep calling rx_ipc when offload is disabled so that the hardware is still programmed with the requested state. Found while investigating RX checksum offload behavior on H616. Maxime Chevallier reproduced the capability loss on AgileX5, CycloneV and STM32MP1 and verified that this change fixes it. Fixes: d2afb5bdffde3 ("stmmac: fix the rx csum feature") Reviewed-by: Maxime Chevallier Tested-by: Maxime Chevallier Signed-off-by: James Hilliard --- Changes in v2: - Correct the Fixes tag to reference the mainline commit. - Add Maxime Chevallier's Reviewed-by and Tested-by tags. - Include the discovery and hardware confirmation context. - Link to v1: https://patch.msgid.link/20261115-submit-stmmac-rx-checksum-capability-v1-v1-1-ea26fa3689be@gmail.com --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 25894771e9e9..e162976be2e6 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3723,7 +3723,7 @@ static int stmmac_hw_setup(struct net_device *dev) stmmac_safety_feat_configuration(priv); ret = stmmac_rx_ipc(priv, priv->hw); - if (!ret) { + if (priv->hw->rx_csum && !ret) { netdev_warn(priv->dev, "RX IPC Checksum Offload disabled\n"); priv->plat->rx_coe = STMMAC_RX_COE_NONE; priv->hw->rx_csum = 0; --- base-commit: 5e9b2ad9b8384cd3c417cd5e2c3bc7eee4a72791 base-tree: git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git main change-id: 20261115-submit-stmmac-rx-checksum-capability-v1-ef6645788992 Best regards, -- James Hilliard