Use the proper refcount-aware helper sctp_auth_shkey_release() instead of kfree() when freeing cur_key in the error path of sctp_auth_set_key(). While both are equivalent in the current code, using the helper maintains abstraction consistency and prevents potential issues if the code is reordered in the future. Signed-off-by: Wentao Liang --- net/sctp/auth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/auth.c b/net/sctp/auth.c index be9782760f50..84708f87392f 100644 --- a/net/sctp/auth.c +++ b/net/sctp/auth.c @@ -753,7 +753,7 @@ int sctp_auth_set_key(struct sctp_endpoint *ep, /* Create a new key data based on the info passed in */ key = sctp_auth_create_key(auth_key->sca_keylength, GFP_KERNEL); if (!key) { - kfree(cur_key); + sctp_auth_shkey_release(cur_key); return -ENOMEM; } -- 2.39.5 (Apple Git-154)