Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL check. Change generated with coccinelle. To: Luis Chamberlain To: Petr Pavlu To: Daniel Gomez To: Sami Tolvanen To: Aaron Tomlin Cc: linux-modules@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Philipp Hahn --- kernel/module/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index c3ce106c70af165e2dc1a3c79f5a074a5c3e3d34..7f62f0620dcd75960e431f7af3d1cadf4cc41e4b 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -1551,7 +1551,7 @@ static int simplify_symbols(struct module *mod, const struct load_info *info) case SHN_UNDEF: ksym = resolve_symbol_wait(mod, info, name); /* Ok if resolved. */ - if (ksym && !IS_ERR(ksym)) { + if (!IS_ERR_OR_NULL(ksym)) { sym[i].st_value = kernel_symbol_value(ksym); break; } -- 2.43.0