The bug the comment describes was fixed by commit 61c43780e944 ("devlink: fix port dump cmd type") two years ago. devlink_nl_port_get_dump_one() fills DEVLINK_CMD_PORT_NEW (7), not DEVLINK_CMD_NEW (3) now. Note that this change is likely a noop. _dictify_ops_directional() picks the "do" section's value when an op has both "do" and "dump". Signed-off-by: Jakub Kicinski --- Documentation/netlink/specs/devlink.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml index d933b205ee86..0e0791d4e2c7 100644 --- a/Documentation/netlink/specs/devlink.yaml +++ b/Documentation/netlink/specs/devlink.yaml @@ -1401,7 +1401,6 @@ doc: Partial family for Devlink. request: attributes: *dev-id-attrs reply: - value: 3 # due to a bug, port dump returns DEVLINK_CMD_NEW attributes: *port-id-attrs - -- 2.55.0