For ternary operators in the form of "a ? true : false", if 'a' itself returns a boolean result, the ternary operator can be omitted. Remove redundant ternary operators to clean up the code. Signed-off-by: Liao Yuanhong --- drivers/net/ethernet/brocade/bna/bfa_ioc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c index 92c7639d1fc7..5bd99dec7490 100644 --- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c +++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c @@ -1794,8 +1794,7 @@ bfa_nw_ioc_fwver_cmp(struct bfa_ioc *ioc, struct bfi_ioc_image_hdr *fwhdr) else if (smem_flash_cmp == BFI_IOC_IMG_VER_SAME) return true; else - return (drv_smem_cmp == BFI_IOC_IMG_VER_SAME) ? - true : false; + return drv_smem_cmp == BFI_IOC_IMG_VER_SAME; } /* Return true if current running version is valid. Firmware signature and -- 2.34.1