The Rockchip dwmac glue driver now supports SGMII on RK3568 and requires a PCS, referenced through the "pcs-handle" property. The property is parsed by rk_pcs_init() and a missing phandle fails the probe, so describe it in the binding and require it when phy-mode is "sgmii". Signed-off-by: Coia Prant --- .../devicetree/bindings/net/rockchip-dwmac.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml index 80c252845349c..67b21ea77ec96 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml @@ -120,6 +120,12 @@ properties: maximum: 0x7F default: 0x10 + pcs-handle: + description: + Specifies a reference to a node representing the PCS device + connected to this GMAC. Required when phy-mode is "sgmii". + maxItems: 1 + phy-supply: description: PHY regulator @@ -159,6 +165,15 @@ allOf: clocks: minItems: 5 + - if: + properties: + phy-mode: + contains: + const: sgmii + then: + required: + - pcs-handle + unevaluatedProperties: false examples: -- 2.47.3