d_real() is about to be able to fail for D_REAL_DATA. So switch ipe_build_eval_ctx() from d_real_inode() to d_real_data_inode() and deal with the error. Currently, if overlayfs fails to resolve the data of a file it hands back the overlayfs inode and IPE evaluates the policy against that. The overlayfs inode has neither a block device nor any fs-verity state so none of the properties of the file hosting the data are visible. Instead, leave the block device and inode state of the evaluation context unset if the data can't be resolved so the file is evaluated without any dm-verity or fs-verity state. IOW, IPE reaches the same verdict as today but without looking at the overlayfs inode. This is a no-op until d_real() can actually fail. Suggested-by: Fan Wu Link: https://lore.kernel.org/all/4e9a39ac-9ad5-49d8-b0c4-09e665504609@kernel.org Acked-by: Fan Wu Signed-off-by: Christian Brauner (Amutable) --- security/ipe/eval.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/security/ipe/eval.c b/security/ipe/eval.c index 4a7be96c84f03..a2366eb9a47b3 100644 --- a/security/ipe/eval.c +++ b/security/ipe/eval.c @@ -102,9 +102,16 @@ void ipe_build_eval_ctx(struct ipe_eval_ctx *ctx, if (file) { build_ipe_sb_ctx(ctx, file); - ino = d_real_inode(file->f_path.dentry); - build_ipe_bdev_ctx(ctx, ino); - build_ipe_inode_ctx(ctx, ino); + /* + * If the real data inode cannot be resolved, leave the bdev + * and inode fields unset so the file is evaluated without + * dm-verity/fs-verity state. + */ + ino = d_real_data_inode(file->f_path.dentry); + if (!IS_ERR(ino)) { + build_ipe_bdev_ctx(ctx, ino); + build_ipe_inode_ctx(ctx, ino); + } } } -- 2.53.0