__igt_mmap_access() reads the buffer with access_process_vm() without FOLL_FORCE, but creates the mapping with only PROT_WRITE. Request PROT_READ as well so the test remains valid when we fix the ->access fallback to properly check VMA access permissions. Fixes: 9f909e215fea ("drm/i915: Implement vm_ops->access for gdb access into mmaps") Signed-off-by: David Hildenbrand (Arm) --- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c index 303be698891fd..d9c828032a1aa 100644 --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c @@ -1460,7 +1460,8 @@ static int __igt_mmap_access(struct drm_i915_private *i915, if (err) return err; - addr = igt_mmap_offset(i915, offset, obj->base.size, PROT_WRITE, MAP_SHARED); + addr = igt_mmap_offset(i915, offset, obj->base.size, + PROT_READ | PROT_WRITE, MAP_SHARED); if (IS_ERR_VALUE(addr)) return addr; ptr = (unsigned long __user *)addr; -- 2.43.0