mt76_dma_cleanup() calls netif_napi_del() for every RX queue, also for the WED RRO queues of mt7996, which get no NAPI while WED is active. __netif_napi_del() then locks the NULL netdev of that NAPI, and rmmod of mt7996e with WED crashes. Delete only the RX NAPIs that have a netdev. Fixes: 6b470f36616e ("wifi: mt76: Fix memory leak destroying device") Signed-off-by: Felix Fietkau --- drivers/net/wireless/mediatek/mt76/dma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/dma.c b/drivers/net/wireless/mediatek/mt76/dma.c index a67880a9281c..8c0403820299 100644 --- a/drivers/net/wireless/mediatek/mt76/dma.c +++ b/drivers/net/wireless/mediatek/mt76/dma.c @@ -1217,7 +1217,8 @@ void mt76_dma_cleanup(struct mt76_dev *dev) mt76_for_each_q_rx(dev, i) { struct mt76_queue *q = &dev->q_rx[i]; - netif_napi_del(&dev->napi[i]); + if (dev->napi[i].dev) + netif_napi_del(&dev->napi[i]); mt76_dma_rx_cleanup(dev, q); page_pool_destroy(q->page_pool); -- 2.47.3