Three attributes are emitted repeatedly inside their nest: - devlink_nl_region_read_fill() calls devlink_nl_cmd_region_read_chunk_fill() once per 256 byte unit - devlink_nl_region_snapshots_id_put() emits one DEVLINK_ATTR_REGION_SNAPSHOT sub-nest per entry on the region's snapshot list - devlink_nl_linecard_fill() emits one DEVLINK_ATTR_LINECARD_TYPE per linecard->types_count entry In all three cases we're missing the multi-attr properties, and the attributes themselves are missing from the attr list used by C code gen. Signed-off-by: Jakub Kicinski --- Documentation/netlink/specs/devlink.yaml | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml index f23466fb27f9..9d816a0b7da4 100644 --- a/Documentation/netlink/specs/devlink.yaml +++ b/Documentation/netlink/specs/devlink.yaml @@ -1264,6 +1264,7 @@ doc: Partial family for Devlink. attributes: - name: region-snapshot + multi-attr: true - name: dl-region-snapshot @@ -1278,6 +1279,7 @@ doc: Partial family for Devlink. attributes: - name: region-chunk + multi-attr: true - name: dl-region-chunk @@ -1360,6 +1362,7 @@ doc: Partial family for Devlink. attributes: - name: linecard-type + multi-attr: true - name: dl-selftest-id @@ -2045,6 +2048,7 @@ doc: Partial family for Devlink. - index - port-index - region-name + - region-chunks - name: port-param-get @@ -2444,14 +2448,22 @@ doc: Partial family for Devlink. post: devlink-nl-post-doit request: value: 78 - attributes: &linecard-id-attrs + attributes: - bus-name - dev-name - index - linecard-index reply: &linecard-get-reply value: 80 - attributes: *linecard-id-attrs + attributes: + - bus-name + - dev-name + - index + - linecard-index + - linecard-state + - linecard-type + - linecard-supported-types + - nested-devlink dump: request: attributes: *dev-id-attrs -- 2.55.0