set_one_vid() checks list_empty(&ndp->vlan_vids) before acquiring nc->lock and rcu_read_lock(). If ncsi_vlan_rx_kill_vid() removes the last VLAN entry in that window, list_for_each_entry_rcu() executes zero iterations and leaves vid uninitialized on the stack. The subsequent 'if (!vid)' check can then proceed and program stack garbage into ncf->vids[index] and an NCSI_PKT_CMD_SVF command packet. Initialize vid to 0 so that an empty RCU list cleanly hits 'if (!vid)' and returns -1. Found via Clang -Wconditional-uninitialized on an x86_64 allyesconfig build. Verified by building net/ncsi/ncsi-manage.o with LLVM=1 W=1 (-Werror) and -Wconditional-uninitialized; not runtime-tested on NCSI hardware. Fixes: 062b3e1b6d4f ("net/ncsi: Refactor MAC, VLAN filters") Signed-off-by: Ian Rogers --- net/ncsi/ncsi-manage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index 1d63958c4429..f7eca228c281 100644 --- a/net/ncsi/ncsi-manage.c +++ b/net/ncsi/ncsi-manage.c @@ -640,7 +640,7 @@ static int set_one_vid(struct ncsi_dev_priv *ndp, struct ncsi_channel *nc, unsigned long flags; int i, index; void *bitmap; - u16 vid; + u16 vid = 0; if (list_empty(&ndp->vlan_vids)) return -1; -- 2.56.1.708.g77570a6a1d-goog