From: Dragos Tatulea get_num_eqs() can return a negative value when an adversarial FW reports fewer EQs than MLX5_MAX_ASYNC_EQS. Return an error in this case. 0 completion EQs is a valid count, e.g. for an SF whose max_io_eqs is set to 0. Reviewed-by: Yishai Hadas Signed-off-by: Dragos Tatulea --- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eq.c b/drivers/net/ethernet/mellanox/mlx5/core/eq.c index d11ec263d53c..b34670eb037c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eq.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eq.c @@ -1195,9 +1195,13 @@ static int get_num_eqs(struct mlx5_core_dev *dev) int mlx5_eq_table_create(struct mlx5_core_dev *dev) { struct mlx5_eq_table *eq_table = dev->priv.eq_table; - int err; + int err, num_eqs; + + num_eqs = get_num_eqs(dev); + if (num_eqs < 0) + return -EINVAL; - eq_table->max_comp_eqs = get_num_eqs(dev); + eq_table->max_comp_eqs = num_eqs; err = create_async_eqs(dev); if (err) { mlx5_core_err(dev, "Failed to create async EQs\n"); -- 2.18.1