From: Christopher Griffin ath12k_peer_assoc_h_he() copies each 6-bit PPE threshold of a peer's HE capabilities into the WMI layout one bit at a time, shifting it in from the top: val >>= 1, then the new bit at bit 5, six times over. After the sixth bit, bit i of the field sits at bit i of val, so put it there directly. No functional change. This change and its message were written with Claude, an AI coding assistant. Suggested-by: Rameshkumar Sundaram Link: https://lore.kernel.org/all/b60c4c56-483b-406e-92ab-643b0fdf2dc8@oss.qualcomm.com/ Signed-off-by: Christopher Griffin --- drivers/net/wireless/ath/ath12k/mac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index 9fd3841f71b71..12dfac1d3b42c 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -2731,9 +2731,8 @@ static void ath12k_peer_assoc_h_he(struct ath12k *ar, if ((arg->peer_ppet.ru_bit_mask & BIT(ru)) == 0) continue; for (i = 0; i < 6; i++) { - val >>= 1; val |= ((he_cap->ppe_thres[bit / 8] >> - (bit % 8)) & 0x1) << 5; + (bit % 8)) & 0x1) << i; bit++; } arg->peer_ppet.ppet16_ppet8_ru3_ru0[nss] |= -- 2.43.0