When executing "./test_progs -t fexit_bpf2bpf", there are 5 failures with the same log: ; tcp->check++; @ test_pkt_access.c:98 226: (69) r1 = *(u16 *)(r2 +16) misaligned packet access off 2+(0x0; 0x3f)+16 size 2 ... libbpf: prog 'test_pkt_access': failed to load: -EACCES libbpf: failed to load object './test_pkt_access.bpf.o' This is because CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS is not set on certain processors that lack hardware unaligned access support. In this case, the affected tests should be skipped. Add a get_unaligned_access_enabled() helper and use it to skip the tests gracefully if the program fails to load with -EACCES. Before: $ sudo ./test_progs -t fexit_bpf2bpf | tail -1 Summary: 0/10 PASSED, 1 SKIPPED, 1/5 FAILED After: $ sudo ./test_progs -t fexit_bpf2bpf | tail -1 Summary: 1/10 PASSED, 6 SKIPPED, 0/0 FAILED Signed-off-by: Tiezhu Yang --- .../testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c | 11 +++++++++++ tools/testing/selftests/bpf/unpriv_helpers.c | 5 +++++ tools/testing/selftests/bpf/unpriv_helpers.h | 1 + 3 files changed, 17 insertions(+) diff --git a/tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c b/tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c index d2f2dcc0f2e1..1c0e93dcb3ce 100644 --- a/tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c +++ b/tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c @@ -3,6 +3,7 @@ #include #include #include +#include #include "bind4_prog.skel.h" #include "freplace_progmap.skel.h" #include "fentry_sleepable.skel.h" @@ -76,6 +77,11 @@ static void test_fexit_bpf2bpf_common(const char *obj_file, err = bpf_prog_test_load(target_obj_file, BPF_PROG_TYPE_UNSPEC, &tgt_obj, &tgt_fd); + if (err < 0 && errno == EACCES && !get_unaligned_access_enabled()) { + test__skip(); + return; + } + if (!ASSERT_OK(err, "tgt_prog_load")) return; @@ -297,6 +303,11 @@ static void test_fmod_ret_freplace(void) err = bpf_prog_test_load(tgt_name, BPF_PROG_TYPE_UNSPEC, &pkt_obj, &pkt_fd); + if (err < 0 && errno == EACCES && !get_unaligned_access_enabled()) { + test__skip(); + return; + } + /* the target prog should load fine */ if (CHECK(err, "tgt_prog_load", "file %s err %d errno %d\n", tgt_name, err, errno)) diff --git a/tools/testing/selftests/bpf/unpriv_helpers.c b/tools/testing/selftests/bpf/unpriv_helpers.c index c8dd5d848584..54ce342b3fe4 100644 --- a/tools/testing/selftests/bpf/unpriv_helpers.c +++ b/tools/testing/selftests/bpf/unpriv_helpers.c @@ -161,3 +161,8 @@ bool get_kasan_multi_shot_enabled(void) { return cmdline_contains("kasan_multi_shot"); } + +bool get_unaligned_access_enabled(void) +{ + return config_contains("CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y") == 1; +} diff --git a/tools/testing/selftests/bpf/unpriv_helpers.h b/tools/testing/selftests/bpf/unpriv_helpers.h index c24d53e14f3a..6e3ad636ea83 100644 --- a/tools/testing/selftests/bpf/unpriv_helpers.h +++ b/tools/testing/selftests/bpf/unpriv_helpers.h @@ -9,3 +9,4 @@ bool get_unpriv_sysctl_disabled(void); bool get_unpriv_mitigations_disabled(void); bool get_kasan_jit_enabled(void); bool get_kasan_multi_shot_enabled(void); +bool get_unaligned_access_enabled(void); -- 2.42.0