Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL check. Change generated with coccinelle. To: Johannes Berg Cc: linux-wireless@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Philipp Hahn --- net/wireless/reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index 1c5c38d18febd511285bc4aab93a60b4287dc054..222764a151ea25bec6179dbaffa87f34fdbf8da6 100644 --- a/net/wireless/reg.c +++ b/net/wireless/reg.c @@ -1014,7 +1014,7 @@ static void regdb_fw_cb(const struct firmware *fw, void *context) } rtnl_lock(); - if (regdb && !IS_ERR(regdb)) { + if (!IS_ERR_OR_NULL(regdb)) { /* negative case - a bug * positive case - can happen due to race in case of multiple cb's in * queue, due to usage of asynchronous callback -- 2.43.0