Typically at this point, interrupt processing for the device, DMA and other changes to the device's external state must be prohibited. For VFIO AP, there is no physical DMA device virtualized by the vfio-ap device . It merely manages the guest's AP configuration that identifies the devices passed through to the guest, but does not have access to any of them. Those AP devices are passed through and controlled exclusively by the SIE program used to start the guest. The only thing to do at this point is release all migration objects used to manage migration of the guest. Signed-off-by: Anthony Krowiak --- drivers/s390/crypto/vfio_ap_migration.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/s390/crypto/vfio_ap_migration.c b/drivers/s390/crypto/vfio_ap_migration.c index ebb3b78b1e19..6074ccfb9240 100644 --- a/drivers/s390/crypto/vfio_ap_migration.c +++ b/drivers/s390/crypto/vfio_ap_migration.c @@ -931,10 +931,18 @@ vfio_ap_transition_to_state(struct ap_matrix_mdev *matrix_mdev, return NULL; } + /* + * Stop the operation of the vfio-ap device. Since the vfio-ap device + * does not virtualize a DMA device, there is no physical device to + * stop; so, the only thing left to do is release the migration files + * used to process the vfio device migration. Note that this state + * transition is for the vfio-ap device on the source host. + */ if (cur_state == VFIO_DEVICE_STATE_STOP_COPY && new_state == VFIO_DEVICE_STATE_STOP) { - /* TODO */ - return ERR_PTR(-EOPNOTSUPP); + vfio_ap_release_mig_files(matrix_mdev); + + return NULL; } if ((cur_state == VFIO_DEVICE_STATE_STOP && -- 2.52.0