Some embedded board designs use GPIO-controlled regulators for the DP83867 power rails. Add dp83867_power_on() to enable all four supply domains at probe time. Absent supplies are silently skipped, so boards that do not describe them are unaffected. When any supply is newly enabled the driver sleeps for 200 ms before returning. This satisfies the post power-up stabilisation requirement mentioned in section 6.6 of the DP83867E/IS/CS datasheet. Acked-by: Lorenzo Bianconi Acked-by: Andrew Davis Reviewed-by: Andrew Lunn Signed-off-by: Mohd Ayaan Anwar --- v4: Sashiko suggested adding a check to skip dp83867_power_on if CONFIG_REGULATOR was not enabled, to avoid unintentional delay due to its code stub. I have kept the Acked- and Reviewed-by tags since it's a small if check requested by the AI review. I can drop them if required, please let me know. --- drivers/net/phy/dp83867.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index b4b4931c6f8c..ed8b3089e8e0 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -16,6 +16,7 @@ #include #include #include +#include #include @@ -730,11 +731,45 @@ static int dp83867_resume(struct phy_device *phydev) return 0; } +static int dp83867_power_on(struct phy_device *phydev) +{ + static const char * const supply_names[] = { + "vdda-2p5", "vdd-1p0", "vdda-1p8", "vddio", + }; + struct device *dev = &phydev->mdio.dev; + bool supplies_enabled = false; + int i, ret; + + if (!IS_ENABLED(CONFIG_REGULATOR)) + return 0; + + for (i = 0; i < ARRAY_SIZE(supply_names); i++) { + ret = devm_regulator_get_enable_optional(dev, supply_names[i]); + if (ret == -ENODEV) + continue; + if (ret) + return dev_err_probe(dev, ret, + "failed to enable %s supply\n", + supply_names[i]); + supplies_enabled = true; + } + + /* Datasheet section 6.6 suggests a 200ms post power-up stabilization */ + if (supplies_enabled) + fsleep(200000); + + return 0; +} + static int dp83867_probe(struct phy_device *phydev) { struct dp83867_private *dp83867; int ret; + ret = dp83867_power_on(phydev); + if (ret) + return ret; + dp83867 = devm_kzalloc_obj(&phydev->mdio.dev, *dp83867); if (!dp83867) return -ENOMEM; -- 2.34.1