vmxnet3_rq_cleanup_all() clears adapter->xdp_bpf_prog. It is called from vmxnet3_quiesce_dev(), so on every MTU change, down/up, ring resize, reset work and resume. After that the driver no longer runs XDP, while the core still reports the program as attached, and the driver's reference to the program is never dropped: a later detach finds xdp_bpf_prog already NULL and returns early. Seen on 6.12.117 and 7.2.12: after "ip link set dev X mtu 1400", "ip link set dev X down; ip link set dev X up" or "ethtool -G X rx 512", the attached program is no longer called, and each detached program stays loaded. Do not clear the pointer there. The program is exchanged and released by vmxnet3_xdp_set(), which also runs when the device is unregistered. Rx rings are then recreated in XDP mode after a reset, as vmxnet3_xdp_enabled() stays true. Since the program now survives an MTU change, reject an MTU above VMXNET3_XDP_MAX_MTU while XDP is attached, as vmxnet3_xdp_set() already refuses to attach a program at such an MTU. The problem was found and analysed, and this patch drafted, with the help of an AI coding assistant. It was reproduced and tested on the reporter's lab systems as described in the cover letter. Fixes: 54f00cce1178 ("vmxnet3: Add XDP support.") Signed-off-by: Philipp Sudakas --- drivers/net/vmxnet3/vmxnet3_drv.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index fb98eb7..e84bf11 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -2104,7 +2104,6 @@ vmxnet3_rq_cleanup_all(struct vmxnet3_adapter *adapter) for (i = 0; i < adapter->num_rx_queues; i++) vmxnet3_rq_cleanup(&adapter->rx_queue[i], adapter); - rcu_assign_pointer(adapter->xdp_bpf_prog, NULL); } @@ -3663,6 +3662,11 @@ vmxnet3_change_mtu(struct net_device *netdev, int new_mtu) struct vmxnet3_adapter *adapter = netdev_priv(netdev); int err = 0; + if (vmxnet3_xdp_enabled(adapter) && new_mtu > VMXNET3_XDP_MAX_MTU) { + netdev_err(netdev, "MTU %d too large for XDP\n", new_mtu); + return -EINVAL; + } + /* * Reset_work may be in the middle of resetting the device, wait for its * completion. -- 2.47.3