From: Cunhao Lu <1579567540@qq.com> rkcanfd_open() enables RX offload before requesting the IRQ. If request_irq() fails, the error path leaves the offload enabled. A later open calls napi_enable() on an already enabled NAPI instance. Disable RX offload on that error path before stopping the controller and releasing the runtime PM reference. Fixes: ff60bfbaf67f ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller") Cc: stable@vger.kernel.org Signed-off-by: Cunhao Lu <1579567540@qq.com> --- Changes in v7: - Split the open error cleanup into a separate patch. Changes in v3: - Disable RX offload when request_irq() fails during open. --- drivers/net/can/rockchip/rockchip_canfd-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/can/rockchip/rockchip_canfd-core.c b/drivers/net/can/rockchip/rockchip_canfd-core.c index 59a79fe057e6..d05264605efc 100644 --- a/drivers/net/can/rockchip/rockchip_canfd-core.c +++ b/drivers/net/can/rockchip/rockchip_canfd-core.c @@ -747,6 +747,7 @@ static int rkcanfd_open(struct net_device *ndev) return 0; out_rkcanfd_chip_stop: + can_rx_offload_disable(&priv->offload); rkcanfd_chip_stop_sync(priv, CAN_STATE_STOPPED); pm_runtime_put(ndev->dev.parent); out_close_candev: -- 2.34.1