The LAG lower state information that is passed to drivers via the NETDEV_CHANGELOWERSTATE notifier only indicates whether the lower device is enabled for transmission ('tx_enabled'). Drivers such as mlxsw use it to enable or disable both collection and distribution on the port. This is not enough for an 802.3ad bond with coupled control disabled, where a port can be enabled for collection, but not for distribution. Add an 'rx_enabled' field that indicates whether the lower device is enabled for reception. For now, set it to the value of 'tx_enabled' in all the LAG drivers. A subsequent patch will set it differently in the bond driver. Reviewed-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/bonding/bond_main.c | 1 + drivers/net/net_failover.c | 1 + drivers/net/team/team_core.c | 1 + include/linux/netdevice.h | 3 ++- 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 167503d1fd15..7eb3ff82ec96 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1831,6 +1831,7 @@ void bond_lower_state_changed(struct slave *slave) info.link_up = slave->link == BOND_LINK_UP || slave->link == BOND_LINK_FAIL; info.tx_enabled = bond_is_active_slave(slave); + info.rx_enabled = info.tx_enabled; netdev_lower_state_changed(slave->dev, &info); } diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c index 1b5213e87070..c4d39f8b8802 100644 --- a/drivers/net/net_failover.c +++ b/drivers/net/net_failover.c @@ -451,6 +451,7 @@ static void net_failover_lower_state_changed(struct net_device *slave_dev, else info.tx_enabled = true; } + info.rx_enabled = info.tx_enabled; netdev_lower_state_changed(slave_dev, &info); } diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c index cfb833c307c1..def94cbc8384 100644 --- a/drivers/net/team/team_core.c +++ b/drivers/net/team/team_core.c @@ -88,6 +88,7 @@ static void team_lower_state_changed(struct team_port *port) info.link_up = port->linkup; info.tx_enabled = team_port_tx_enabled(port); + info.rx_enabled = info.tx_enabled; netdev_lower_state_changed(port->dev, &info); } diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 0325c6f2a7d1..694b6d29f680 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -3239,7 +3239,8 @@ struct netdev_lag_upper_info { struct netdev_lag_lower_state_info { u8 link_up : 1, - tx_enabled : 1; + tx_enabled : 1, + rx_enabled : 1; }; #include -- 2.56.0