Once outgoing sessions are blocked during reboot, every failure path after liveupdate_reboot() must release that state again. Today kernel_kexec() sets liveupdate_prepared only after liveupdate_reboot() returns successfully, so a partial failure inside liveupdate_reboot() skips the abort path entirely. The kho_finalize() failure path also leaves the LUO session state frozen. This is dangerous because a failed kexec attempt can leave userspace with outgoing sessions stuck in reboot state, blocking release and preserve paths until the next reboot. Export a liveupdate_reboot_abort() helper, call it from the kho_finalize() error path, and mark liveupdate as prepared before entering liveupdate_reboot(). That makes every failed handover attempt unwind the session state and wake blocked waiters. Signed-off-by: Oskar Gerlicz Kowalczuk --- include/linux/liveupdate.h | 5 +++++ kernel/kexec_core.c | 4 ++++ kernel/liveupdate/luo_core.c | 11 ++++++++++- kernel/liveupdate/luo_internal.h | 1 + kernel/liveupdate/luo_session.c | 23 +++++++++++++++++++++++ 5 files changed, 43 insertions(+), 1 deletion(-) diff --git a/include/linux/liveupdate.h b/include/linux/liveupdate.h index dd11fdc76a5f..d93b043a0421 100644 --- a/include/linux/liveupdate.h +++ b/include/linux/liveupdate.h @@ -226,6 +226,7 @@ bool liveupdate_enabled(void); /* Called during kexec to tell LUO that entered into reboot */ int liveupdate_reboot(void); +void liveupdate_reboot_abort(void); int liveupdate_register_file_handler(struct liveupdate_file_handler *fh); int liveupdate_unregister_file_handler(struct liveupdate_file_handler *fh); @@ -250,6 +251,10 @@ static inline int liveupdate_reboot(void) return 0; } +static inline void liveupdate_reboot_abort(void) +{ +} + static inline int liveupdate_register_file_handler(struct liveupdate_file_handler *fh) { return -EOPNOTSUPP; diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c index 2fea396d29b9..492c17f7e96f 100644 --- a/kernel/kexec_core.c +++ b/kernel/kexec_core.c @@ -1139,6 +1139,7 @@ bool kexec_load_permitted(int kexec_image_type) int kernel_kexec(void) { int error = 0; + bool liveupdate_prepared = false; if (!kexec_trylock()) return -EBUSY; @@ -1147,6 +1148,7 @@ int kernel_kexec(void) goto Unlock; } + liveupdate_prepared = true; error = liveupdate_reboot(); if (error) goto Unlock; @@ -1231,6 +1233,8 @@ int kernel_kexec(void) #endif Unlock: + if (error && liveupdate_prepared) + liveupdate_reboot_abort(); kexec_unlock(); return error; } diff --git a/kernel/liveupdate/luo_core.c b/kernel/liveupdate/luo_core.c index dda7bb57d421..95a0b81ce60d 100644 --- a/kernel/liveupdate/luo_core.c +++ b/kernel/liveupdate/luo_core.c @@ -233,8 +233,9 @@ int liveupdate_reboot(void) err = kho_finalize(); if (err) { pr_err("kho_finalize failed %d\n", err); + liveupdate_reboot_abort(); /* - * kho_finalize() may return libfdt errors, to aboid passing to + * kho_finalize() may return libfdt errors, to avoid passing to * userspace unknown errors, change this to EAGAIN. */ err = -EAGAIN; @@ -243,6 +244,14 @@ int liveupdate_reboot(void) return err; } +void liveupdate_reboot_abort(void) +{ + if (!liveupdate_enabled()) + return; + + luo_session_abort_reboot(); +} + /** * liveupdate_enabled - Check if the live update feature is enabled. * diff --git a/kernel/liveupdate/luo_internal.h b/kernel/liveupdate/luo_internal.h index 8083d8739b09..ad09ea756156 100644 --- a/kernel/liveupdate/luo_internal.h +++ b/kernel/liveupdate/luo_internal.h @@ -82,6 +82,7 @@ int luo_session_retrieve(const char *name, struct file **filep); int __init luo_session_setup_outgoing(void *fdt); int __init luo_session_setup_incoming(void *fdt); int luo_session_serialize(void); +void luo_session_abort_reboot(void); int luo_session_deserialize(void); bool luo_session_quiesce(void); void luo_session_resume(void); diff --git a/kernel/liveupdate/luo_session.c b/kernel/liveupdate/luo_session.c index ee5ea2a8ed3f..39215e5eda7a 100644 --- a/kernel/liveupdate/luo_session.c +++ b/kernel/liveupdate/luo_session.c @@ -649,6 +649,29 @@ int luo_session_serialize(void) return err; } +void luo_session_abort_reboot(void) +{ + struct luo_session_header *sh = &luo_session_global.outgoing; + struct luo_session *session; + int i = 0; + + guard(rwsem_write)(&sh->rwsem); + if (!READ_ONCE(sh->rebooting)) + return; + + list_for_each_entry(session, &sh->list, list) { + if (i >= sh->header_ser->count) + break; + + luo_session_unfreeze_one(session, &sh->ser[i]); + memset(&sh->ser[i], 0, sizeof(sh->ser[i])); + i++; + } + + sh->header_ser->count = 0; + luo_session_reboot_done(sh); +} + /** * luo_session_quiesce - Ensure no active sessions exist and lock session lists. * -- 2.53.0