From: "Gregory Price (Meta)" Compaction serves the ordinary allocation domain. Restrict it to N_MEMORY_COMMON: - start kcompactd only on common nodes, at boot and hotplug. - compact only common nodes for /proc/sys/vm/compact_memory, and trigger proactive compaction only on common nodes. compact_memory and the proactiveness trigger walked every online node before. Memoryless nodes have nothing to compact and no kcompactd, so leaving them out changes nothing. Direct compaction serves an allocation from its own zonelist, so it is left alone. Signed-off-by: Gregory Price (Meta) --- mm/compaction.c | 6 +++--- mm/memory_hotplug.c | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 426563acf7ac..879f372a891e 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -2973,7 +2973,7 @@ static int compact_nodes(void) /* Flush pending updates to the LRU lists */ lru_add_drain_all(); - for_each_online_node(nid) { + for_each_node_state(nid, N_MEMORY_COMMON) { ret = compact_node(NODE_DATA(nid), false); if (ret) return ret; @@ -2992,7 +2992,7 @@ static int compaction_proactiveness_sysctl_handler(const struct ctl_table *table return rc; if (write && sysctl_compaction_proactiveness) { - for_each_online_node(nid) { + for_each_node_state(nid, N_MEMORY_COMMON) { pg_data_t *pgdat = NODE_DATA(nid); if (pgdat->proactive_compact_trigger) @@ -3366,7 +3366,7 @@ static int __init kcompactd_init(void) { int nid; - for_each_node_state(nid, N_MEMORY) + for_each_node_state(nid, N_MEMORY_COMMON) kcompactd_run(nid); register_sysctl_init("vm", vm_compaction); return 0; diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index a599fcad65d3..6b6873cfbc5a 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1224,7 +1224,8 @@ int online_pages(unsigned long pfn, unsigned long nr_pages, if (node_state(nid, N_MEMORY_COMMON)) kswapd_run(nid); - kcompactd_run(nid); + if (node_state(nid, N_MEMORY_COMMON)) + kcompactd_run(nid); if (node_arg.nid >= 0) /* First memory added successfully. Notify consumers. */ -- 2.56.1