The channel survey query removes a fixed response header and reads four MIB entries without checking that they are present. A truncated firmware response can cause out-of-bounds reads. Require the header and complete MIB array before pulling the skb. Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices") Signed-off-by: Jiale Yao --- drivers/net/wireless/mediatek/mt76/mt7996/mcu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c index c70d7ad3148c..5391666553d9 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c @@ -4627,6 +4627,10 @@ int mt7996_mcu_get_chan_mib_info(struct mt7996_phy *phy, bool chan_switch) &req, sizeof(req), true, &skb); if (ret) return ret; + if (skb->len < sizeof(req.hdr) + IDX_NUM * sizeof(*res)) { + dev_kfree_skb(skb); + return -EINVAL; + } skb_pull(skb, sizeof(req.hdr)); -- 2.34.1