stm32_dmamux_route_allocate() calls pm_runtime_resume_and_get() while holding dmamux->lock with interrupts disabled. The runtime-resume callback stm32_dmamux_runtime_resume() calls clk_prepare_enable(), which can sleep, and the device is not marked pm_runtime_irq_safe(), so this can sleep in atomic context. The lock does not protect anything here: the dma_inuse bitmap is already updated under the lock earlier in the function, and this second critical section only wraps the pm_runtime call. Drop the lock around it. Fixes: 4f3ceca254e0 ("dmaengine: stm32-dmamux: Add PM Runtime support") Cc: stable@vger.kernel.org Signed-off-by: Hyunjung Ko --- drivers/dma/stm32/stm32-dmamux.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/dma/stm32/stm32-dmamux.c b/drivers/dma/stm32/stm32-dmamux.c index 57318715d9f3..890328b3d302 100644 --- a/drivers/dma/stm32/stm32-dmamux.c +++ b/drivers/dma/stm32/stm32-dmamux.c @@ -139,13 +139,9 @@ static void *stm32_dmamux_route_allocate(struct of_phandle_args *dma_spec, } /* Set dma request */ - spin_lock_irqsave(&dmamux->lock, flags); ret = pm_runtime_resume_and_get(&pdev->dev); - if (ret < 0) { - spin_unlock_irqrestore(&dmamux->lock, flags); + if (ret < 0) goto err_put_dma_spec_np; - } - spin_unlock_irqrestore(&dmamux->lock, flags); mux->request = dma_spec->args[0]; -- 2.43.0