The assignment `x = NULL` sets the local parameter variable instead of `*x`, which is a no-op since `*x` was already set to NULL on the line above. Remove the dead assignment. Signed-off-by: wangxuewen --- tools/mm/slabinfo.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/mm/slabinfo.c b/tools/mm/slabinfo.c index 39f7eae7eecd..ac00daee41d1 100644 --- a/tools/mm/slabinfo.c +++ b/tools/mm/slabinfo.c @@ -194,7 +194,6 @@ static unsigned long get_obj_and_str(const char *name, char **x) *x = NULL; if (!read_obj(name)) { - x = NULL; return 0; } result = strtoul(buffer, &p, 10); -- 2.25.1