Currently, phy_polling_mode() enables polling only if: - the PHY is in interrupt-less mode, or - the driver provides an update_stats() callback. This excludes drivers that implement get_next_update_time() to support adaptive polling but do not provide update_stats(). As a result, the state machine timer will not run, and the get_next_update_time() callback is never used. This patch extends the polling condition to include drivers that implement get_next_update_time(). This change is required to support adaptive polling in the SMSC LAN9512/LAN8700 PHY family, which cannot reliably use interrupts. No in-tree drivers rely on this mechanism yet, so existing behavior is unchanged. If any out-of-tree driver incorrectly implements get_next_update_time(), enabling polling is still the correct behavior. Fixes: 8bf47e4d7b87 ("net: phy: Add support for driver-specific next update time") Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn --- changes v2: - update commit message --- include/linux/phy.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/phy.h b/include/linux/phy.h index 4c2b8b6e7187..2688c0435b9b 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -1636,7 +1636,7 @@ static inline bool phy_polling_mode(struct phy_device *phydev) if (phydev->drv->flags & PHY_POLL_CABLE_TEST) return true; - if (phydev->drv->update_stats) + if (phydev->drv->update_stats || phydev->drv->get_next_update_time) return true; return phydev->irq == PHY_POLL; -- 2.39.5