Add shell tests verifying perf inject --sample-buildids (with basic samples, callchains, pipe mode, and kernel samples) and perf record --buildid-offset across per-thread, system-wide, workload, and callgraph modes. Signed-off-by: Ian Rogers --- tools/perf/tests/shell/inject_bid_offset.sh | 179 ++++++++++++++++++++ tools/perf/tests/shell/record.sh | 74 ++++++++ 2 files changed, 253 insertions(+) create mode 100755 tools/perf/tests/shell/inject_bid_offset.sh diff --git a/tools/perf/tests/shell/inject_bid_offset.sh b/tools/perf/tests/shell/inject_bid_offset.sh new file mode 100755 index 000000000000..9be2e3323558 --- /dev/null +++ b/tools/perf/tests/shell/inject_bid_offset.sh @@ -0,0 +1,179 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 +# perf inject --sample-buildids test + +set -e +set -o pipefail + +shelldir=$(dirname "$0") +# shellcheck source=lib/perf_has_symbol.sh +. "${shelldir}"/lib/perf_has_symbol.sh + +sym="noploop" + +skip_test_missing_symbol ${sym} + +temp_dir=$(mktemp -d /tmp/perf-test-bid-offset.XXXXXXXXXX) + +prog="perf test -w noploop" +[ "$(uname -m)" = "s390x" ] && prog="$prog 3" +err=0 + +cleanup() { + local exit_code=${1:-$?} + trap - EXIT TERM INT + if [ "${exit_code}" -ne 0 ] || [ "${err}" -ne 0 ]; then + echo "Test failed! Preserving temp directory: ${temp_dir}" + exit 1 + fi + if [[ "${temp_dir}" =~ ^/tmp/perf-test-bid-offset\. ]]; then + rm -rf "${temp_dir}" + fi + exit 0 +} + +trap_cleanup() { + local exit_code=$? + echo "Unexpected signal in ${FUNCNAME[1]}" + cleanup ${exit_code} +} +trap trap_cleanup EXIT TERM INT + +compare_script() { + local orig=$1 + local bid=$2 + local msg=$3 + + perf script -F -ip -i "${orig}" > "${temp_dir}/script_orig.txt" + perf script -F -ip -i "${bid}" > "${temp_dir}/script_bid.txt" + + if [ ! -s "${temp_dir}/script_orig.txt" ]; then + echo "${msg} [Failed - empty perf script output]" + err=1 + elif ! diff -q "${temp_dir}/script_orig.txt" "${temp_dir}/script_bid.txt"; then + echo "${msg} [Failed - perf script output differs]" + err=1 + else + echo "${msg} [Success]" + fi +} + +compare_report() { + local orig=$1 + local bid=$2 + local msg=$3 + + perf report -i "${orig}" --stdio | grep -v '^#' > "${temp_dir}/report_orig.txt" + perf report -i "${bid}" --stdio | grep -v '^#' > "${temp_dir}/report_bid.txt" + + if ! diff -q "${temp_dir}/report_orig.txt" "${temp_dir}/report_bid.txt"; then + echo "${msg} [Failed - perf report output differs]" + err=1 + else + echo "${msg} [Success]" + fi +} + +test_basic() { + echo "Test basic build id offset injection" + local data="${temp_dir}/perf.data.basic" + local data2="${temp_dir}/perf.data2.basic" + + perf record -e task-clock:u -o "${data}" ${prog} >/dev/null 2>&1 + perf inject --sample-buildids -i "${data}" -o "${data2}" >/dev/null 2>&1 + + compare_script "${data}" "${data2}" "Basic injection" +} + +test_callchain() { + echo "Test Callchain build id offset injection" + local data="${temp_dir}/perf.data.callchain" + local data2="${temp_dir}/perf.data2.callchain" + + perf record --call-graph fp -e task-clock:u -o "${data}" ${prog} >/dev/null 2>&1 + perf inject --sample-buildids -i "${data}" -o "${data2}" >/dev/null 2>&1 + + compare_script "${data}" "${data2}" "Callchain injection" +} + +test_pipe() { + echo "Test pipe mode build id offset injection" + local data="${temp_dir}/perf.data.pipe" + local data2="${temp_dir}/perf.data2.pipe" + + perf record -e task-clock:u -o - ${prog} 2>/dev/null | tee "${data}" | \ + perf inject --sample-buildids -o "${data2}" >/dev/null 2>&1 + + compare_script "${data}" "${data2}" "Pipe mode injection" +} + +test_report() { + echo "Test perf report consistency" + local data="${temp_dir}/perf.data.report" + local data2="${temp_dir}/perf.data2.report" + + perf record -e task-clock:u -o "${data}" ${prog} >/dev/null 2>&1 + perf inject --sample-buildids -i "${data}" -o "${data2}" >/dev/null 2>&1 + + compare_report "${data}" "${data2}" "Report consistency" +} + +test_pipe_report() { + echo "Test pipe mode perf report consistency" + local data="${temp_dir}/perf.data.pipe_report" + local data2="${temp_dir}/perf.data2.pipe_report" + + perf record -e task-clock:u -o - ${prog} 2>/dev/null | tee "${data}" | \ + perf inject --sample-buildids -o "${data2}" >/dev/null 2>&1 + + compare_report "${data}" "${data2}" "Pipe Report consistency" +} + +test_kernel() { + echo "Test kernel build id offset injection" + local data="${temp_dir}/perf.data.kernel" + local data2="${temp_dir}/perf.data2.kernel" + local kprog="dd if=/dev/urandom of=/dev/null bs=1M count=50" + + # Not all systems allow kernel profiling, so we check if it succeeds first + if ! perf record -e task-clock:k -o "${data}" ${kprog} >/dev/null 2>&1; then + echo "Kernel injection [Skipped - permissions or support missing]" + return + fi + perf inject --sample-buildids -i "${data}" -o "${data2}" >/dev/null 2>&1 + + compare_script "${data}" "${data2}" "Kernel injection" +} + +test_record_buildid_offset() { + echo "Test perf record --buildid-offset consistency" + local data="${temp_dir}/perf.data.record_orig" + local data2="${temp_dir}/perf.data2.record_bid" + + perf record -e task-clock:u -o "${data}" ${prog} >/dev/null 2>&1 + # We must have the binaries in .build-id cache, which the first record does natively. + # Now record with --buildid-offset. + if ! perf record --buildid-offset -e task-clock:u -o "${data2}" \ + ${prog} >/dev/null 2>&1; then + echo "Record --buildid-offset consistency [Skipped - not supported by kernel]" + return + fi + + # Verify symbolization resolves the workload symbol + if ! perf report -i "${data2}" --stdio | grep -q "${sym}"; then + echo "Record --buildid-offset consistency [Failed - missing ${sym} in perf report]" + err=1 + else + echo "Record --buildid-offset consistency [Success]" + fi +} + +test_basic +test_callchain +test_pipe +test_report +test_pipe_report +test_kernel +test_record_buildid_offset + +cleanup ${err} diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh index e4789e2bcf43..80cee3eedcc3 100755 --- a/tools/perf/tests/shell/record.sh +++ b/tools/perf/tests/shell/record.sh @@ -740,6 +740,79 @@ test_ratio_to_prev() { echo "Basic ratio-to-prev record test [Success]" } +check_buildid_offset() { + perf report --header -D -i "${perfdata}" 2>/dev/null | grep -q "BUILD_ID_OFFSET" +} + +test_buildid_offset() { + echo "buildid-offset test" + local ret=0 + perf_record_with_retry "${perfdata}" "check_buildid_offset" "perf test -w thloop" \ + --buildid-offset || ret=$? + if [ $ret -eq 2 ]; then + echo "buildid-offset test [Skipped not supported]" + return + elif [ $ret -eq 1 ]; then + echo "buildid-offset test [Failed missing output]" + err=1 + return + fi + + # Expand test coverage + ret=0 + perf_record_with_retry "${perfdata}" "check_per_thread" "perf test -w thloop" \ + --buildid-offset --per-thread || ret=$? + if [ $ret -ne 0 ]; then + echo "buildid-offset test [Failed per-thread]" + err=1 + return + fi + + ret=0 + perf_record_with_retry "${perfdata}" "check_system_wide" "perf test -w thloop" \ + --buildid-offset -aB --synth=no || ret=$? + if [ $ret -eq 2 ]; then + echo "buildid-offset system-wide [Skipped not supported]" + elif [ $ret -ne 0 ]; then + echo "buildid-offset test [Failed system-wide]" + err=1 + return + fi + + ret=0 + perf_record_with_retry "${perfdata}" "check_workload" "perf test -w thloop" \ + --buildid-offset || ret=$? + if [ $ret -ne 0 ]; then + echo "buildid-offset test [Failed workload]" + err=1 + return + fi + + case $(uname -m) + in s390x) + cmd_flags="--call-graph dwarf -e cpu-clock";; + *) + cmd_flags="-g";; + esac + + if ! perf record --buildid-offset -o "${perfdata}" $cmd_flags \ + perf test -w brstack > /dev/null 2>&1 + then + echo "buildid-offset test [Failed callgraph record]" + err=1 + return + fi + + if ! perf report -i "${perfdata}" 2>&1 | grep -q "${testsym2}" + then + echo "buildid-offset test [Failed callgraph missing symbol]" + err=1 + return + fi + + echo "buildid-offset test [Success]" +} + # raise the limit of file descriptors to minimum if [[ $default_fd_limit -lt $min_fd_limit ]]; then ulimit -Sn $min_fd_limit @@ -760,6 +833,7 @@ test_precise_max test_callgraph test_acr_sampling test_ratio_to_prev +test_buildid_offset # restore the default value ulimit -Sn $default_fd_limit -- 2.56.1.703.gf848ed807c-goog