i40e_veb_release() counts all VSIs attached to veb->seid in 'n', but only assigns 'vsi' when I40E_VSI_FLAG_VEB_OWNER is set. If a non-floating VEB has a single remaining VSI without I40E_VSI_FLAG_VEB_OWNER (for example if the owner VSI was moved or cleared via debugfs switch operations), n == 1 passes the 'n != 1' check while 'vsi' remains uninitialized on the stack and is immediately dereferenced. Initialize 'vsi' to NULL and refuse to release a non-floating VEB unless both n == 1 and vsi != NULL. Found via an x86_64 LLVM=1 (Clang 21.1.8) allyesconfig audit with -Wconditional-uninitialized enabled; fix and changelog drafted with an AI coding assistant. Build-tested under LLVM=1 W=1 (-Werror) and -Wconditional-uninitialized; not tested on Intel XL710/X722 hardware. Fixes: 08cdde310e22 ("i40e: Fix broken support for floating VEBs") Signed-off-by: Ian Rogers --- drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index abbc71e815ae..8d4213b7dd92 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -14718,7 +14718,7 @@ static void i40e_veb_clear(struct i40e_veb *veb) **/ void i40e_veb_release(struct i40e_veb *veb) { - struct i40e_vsi *vsi, *vsi_it; + struct i40e_vsi *vsi = NULL, *vsi_it; struct i40e_pf *pf; int i, n = 0; @@ -14735,7 +14735,8 @@ void i40e_veb_release(struct i40e_veb *veb) /* Floating VEB has to be empty and regular one must have * single owner VSI. */ - if ((veb->uplink_seid && n != 1) || (!veb->uplink_seid && n != 0)) { + if ((veb->uplink_seid && (n != 1 || !vsi)) || + (!veb->uplink_seid && n != 0)) { dev_info(&pf->pdev->dev, "can't remove VEB %d with %d VSIs left\n", veb->seid, n); -- 2.56.1.708.g77570a6a1d-goog