ceph_handle_snap() stores the unsigned 32-bit split counts from the message header in signed integers. Values with the high bit set become negative and, on 64-bit systems, cause the subsequent pointer arithmetic to move backwards before the message buffer. BUG: KASAN: slab-out-of-bounds in ceph_update_snap_trace (fs/ceph/snap.c:815) Read of size 8 at addr ffff888024f45478 by task kworker/1:3/2220 CPU: 1 UID: 0 PID: 2220 Comm: kworker/1:3 Not tainted 7.4.0-rc2-g7475ea8b5861 #1 PREEMPT(full) Hardware name: QEMU Ubuntu 24.04 PC v2 (i440FX + PIIX, arch_caps fix, 1996), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 Workqueue: ceph-msgr ceph_con_workfn Call Trace: dump_stack_lvl (lib/dump_stack.c:94 lib/dump_stack.c:120) print_report (mm/kasan/report.c:378 mm/kasan/report.c:482) ceph_update_snap_trace (fs/ceph/snap.c:815) ceph_handle_snap (fs/ceph/snap.c:1057) __pfx_ceph_update_snap_trace (./include/linux/list.h:172) down_write (kernel/locking/rwsem.c:1350 kernel/locking/rwsem.c:1356 kernel/locking/rwsem.c:1632) __pfx_down_write (kernel/locking/rwsem.c:602) ceph_handle_snap (fs/ceph/snap.c:1158) mds_dispatch (fs/ceph/mds_client.c:7298) find_held_lock (kernel/locking/lockdep.c:5401) ceph_con_process_message (net/ceph/messenger.c:1413) ceph_con_process_message (net/ceph/messenger.c:1424) ceph_con_in_msg_alloc (net/ceph/messenger.c:2094) ceph_con_v1_try_read (net/ceph/messenger_v1.c:1434) ceph_con_workfn (net/ceph/messenger.c:1576) process_one_work (kernel/workqueue.c:3495) worker_thread (kernel/workqueue.c:3578 kernel/workqueue.c:3659) kthread (kernel/kthread.c:436) ret_from_fork (arch/x86/kernel/process.c:158) ret_from_fork_asm (arch/x86/entry/entry_64.S:245) Kernel Offset: disabled Use u32 for both counts to prevent negative counts from moving the pointer backwards. Fixes: 963b61eb041e ("ceph: snapshot management") Cc: stable@vger.kernel.org Reported-by: co+408fcc361565713f@bugs.sh Assisted-by: LLM Signed-off-by: Kaho Jiang --- fs/ceph/snap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/snap.c b/fs/ceph/snap.c index 9b79a5eaca93..7ed782abfbbc 100644 --- a/fs/ceph/snap.c +++ b/fs/ceph/snap.c @@ -1027,7 +1027,7 @@ void ceph_handle_snap(struct ceph_mds_client *mdsc, void *p = msg->front.iov_base; void *e = p + msg->front.iov_len; struct ceph_mds_snap_head *h; - int num_split_inos, num_split_realms; + u32 num_split_inos, num_split_realms; __le64 *split_inos = NULL, *split_realms = NULL; int i; int locked_rwsem = 0; -- 2.43.0