macvlan_init_module() ignores register_netdevice_notifier() errors and continues module initialization, which can leave macvlan loaded without its netdev notifier registered. Check the error and fail module initialization early. Signed-off-by: Minhong He --- drivers/net/macvlan.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 9a4bc99dbf53..4294b433838a 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -1906,7 +1906,9 @@ static int __init macvlan_init_module(void) { int err; - register_netdevice_notifier(&macvlan_notifier_block); + err = register_netdevice_notifier(&macvlan_notifier_block); + if (err) + return err; err = macvlan_link_register(&macvlan_link_ops); if (err < 0) -- 2.25.1