To eliminate the use of the page pool fields in struct page, the page pool code should use netmem descriptor and APIs instead. However, __netmem_get_pp() still accesses ->pp via struct page. So change it to use struct netmem_desc instead, since ->pp no longer will be available in struct page. While at it, add a helper, pp_page_to_nmdesc(), that can be used to extract netmem_desc from page only if it's pp page. For now that netmem_desc overlays on page, it can be achieved by just casting. Signed-off-by: Byungchul Park --- include/net/netmem.h | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/include/net/netmem.h b/include/net/netmem.h index 535cf17b9134..2b8a7b51ac99 100644 --- a/include/net/netmem.h +++ b/include/net/netmem.h @@ -267,6 +267,17 @@ static inline struct net_iov *__netmem_clear_lsb(netmem_ref netmem) return (struct net_iov *)((__force unsigned long)netmem & ~NET_IOV); } +static inline struct netmem_desc *pp_page_to_nmdesc(struct page *page) +{ + DEBUG_NET_WARN_ON_ONCE(!page_pool_page_is_pp(page)); + + /* XXX: How to extract netmem_desc from page must be changed, + * once netmem_desc no longer overlays on page and will be + * allocated through slab. + */ + return (struct netmem_desc *)page; +} + /** * __netmem_get_pp - unsafely get pointer to the &page_pool backing @netmem * @netmem: netmem reference to get the pointer from @@ -280,7 +291,7 @@ static inline struct net_iov *__netmem_clear_lsb(netmem_ref netmem) */ static inline struct page_pool *__netmem_get_pp(netmem_ref netmem) { - return __netmem_to_page(netmem)->pp; + return pp_page_to_nmdesc(__netmem_to_page(netmem))->pp; } static inline struct page_pool *netmem_get_pp(netmem_ref netmem) -- 2.17.1