The properties nvmem-cells and ti,{min,max}-output-impedance are mutually exclusive as already noted in the ti,max-output-impedance description. As this is only stated in the description and not made explicit in the schema, the binding checker will not catch if this condition is ignored. Make it explicit in the schema, that nmvem-cells can not be used with ti,min-output-impedance or ti,max-output-impedance. Signed-off-by: Steffen Trumtrar --- Documentation/devicetree/bindings/net/ti,dp83867.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Documentation/devicetree/bindings/net/ti,dp83867.yaml index 4bc1f98fd9fe5..7a6fe516bab27 100644 --- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml +++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml @@ -7,9 +7,6 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: TI DP83867 ethernet PHY -allOf: - - $ref: ethernet-controller.yaml# - maintainers: - Andrew Davis @@ -118,6 +115,13 @@ properties: Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h for applicable values. +allOf: + - $ref: ethernet-controller.yaml# + - not: + required: [nvmem-cells, "ti,min-output-impedance"] + - not: + required: [nvmem-cells, "ti,max-output-impedance"] + required: - reg -- 2.54.0