The helper functions _get_nvmet_ports() and _get_nvmet_port_params() use the bash 'nameref' feature, introduced in the bash version 4.3. Currently, blktests README and the check script declare bash version 4.2 as the minimum bash version, leading to a version mismatch. Fix this inconsistency by updating the minimum required bash version to 4.3. Note that bash 4.2 was released in 2011, while bash 4.3 was released in 2014. This change is unlikely to affect blktests users. Signed-off-by: Shin'ichiro Kawasaki --- README.md | 2 +- check | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index e993105..b137a43 100644 --- a/README.md +++ b/README.md @@ -12,7 +12,7 @@ filesystem testing framework. It was originally written by Omar Sandoval and The dependencies are minimal, but make sure you have them installed: -- bash (>= 4.2) +- bash (>= 4.3) - GNU coreutils - GNU awk - util-linux diff --git a/check b/check index a2c19a2..8c113b3 100755 --- a/check +++ b/check @@ -1074,11 +1074,11 @@ _check_dependencies() { local -A required_commands_and_packages local cmd - # Require bash version 4.2 + # Require bash version 4.3 IFS='.' read -r v1 v2 v3 < <(bash --version | grep version | head -1 | \ sed 's/.*version \([0-9.]\+\).*/\1/') - if ((v1 * 65536 + v2 * 256 + v3 < 4 * 65536 + 2 * 256)); then - _warning "bash version is older than 4.2" + if ((v1 * 65536 + v2 * 256 + v3 < 4 * 65536 + 3 * 256)); then + _warning "bash version is older than 4.3" fi # Check dependent commands to run blktests -- 2.53.0