This driver uses devm_request_irq() without including by itself, which would lead to build failures if the headers providing this transitively were to stop providing it. On aarch64, we can see, using KCFLAGS='-H' make drivers/ufs/host/ufs-qcom.o, that the inclusion path is: drivers/ufs/host/ufs-qcom.c -> include/linux/acpi.h -> arch/arm64/include/asm/acpi.h -> include/linux/efi.h -> include/linux/rtc.h -> include/linux/interrupt.h Whereas on armv7, the situation is quite different. This architecture has no CONFIG_ACPI symbol, and therefore on it, does not include , and is not provided that way. It is provided, however, through this "fallback" path: drivers/ufs/host/ufs-qcom.c -> include/linux/phy/phy.h -> include/linux/regulator/consumer.h -> include/linux/suspend.h -> include/linux/swap.h -> include/linux/memcontrol.h -> include/linux/writeback.h -> include/linux/interrupt.h The point is that will stop providing , and this would break the transitive include chain on armv7. Signed-off-by: Vladimir Oltean Reviewed-by: Martin K. Petersen --- Cc: Manivannan Sadhasivam Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" v6->v7: collect tag from Martin v5->v6: patch is new --- drivers/ufs/host/ufs-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 872e4effa60f..c7a02f6ef504 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include -- 2.34.1