Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL check. Change generated with coccinelle. To: Jon Maloy To: "David S. Miller" To: Eric Dumazet To: Jakub Kicinski To: Paolo Abeni To: Simon Horman Cc: netdev@vger.kernel.org Cc: tipc-discussion@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Signed-off-by: Philipp Hahn --- net/tipc/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 4c618c2b871db681e69f7aec8f660d6130a13346..0d9cb21ffbf1539b7740e76521e3aac5fde322e3 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -2971,7 +2971,7 @@ void tipc_sk_reinit(struct net *net) do { rhashtable_walk_start(&iter); - while ((tsk = rhashtable_walk_next(&iter)) && !IS_ERR(tsk)) { + while (!IS_ERR_OR_NULL((tsk = rhashtable_walk_next(&iter)))) { sock_hold(&tsk->sk); rhashtable_walk_stop(&iter); lock_sock(&tsk->sk); -- 2.43.0